Improved MarkdownViewer #1490
Merged
Improved MarkdownViewer #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Features - Uses the latest [github-markdown.css](https://github.com/sindresorhus/github-markdown-css/blob/main/github-markdown.css) file that contains styling support for both dark and light mode. - Table of Contents has an improved design, and: - The width can be resized. - TOC headings are automatically highlighted to help track your position in the file. - Improved fullscreen layout based on Github.com behavior. - External links clicked will open in default browser instead of doing nothing. - Uses [markdownItAnchor](https://github.com/valeriangalliat/markdown-it-anchor) to allow heading anchor links in the file to work. - Uses [highlight.js](https://github.com/highlightjs/highlight.js) to provide syntax highlighting to codeblocks. #### Changes - Made changes to allow the `md2html.html` file to use relative file imports for better maintainability. - MarkdownViewer can now easily be customized by users by modifying files in `<Quicklook data folder>/QuickLook.Plugin.MarkdownViewer/` - Caching and `localStorage` is now supported thanks to these changes. - Prevent default behavior of spacebar scrolling the page, while we use spacebar to dismiss the preview. - Sets `WebView` `DefaultBackgroundColor` to prevent white flash in dark mode. After the page has loaded, sets `DefaultBackgroundColor` back to white to have the expected default behavior on HTML pages that don't specify any background color. #### Clean up - Removed the need for `jQuery`. - Removed old polyfill code.
emako
requested changes
Dec 5, 2024
…ehavior to WebpagePanel
|
@KamilDev Could you provide any markdown file to test the code about |
|
Here's a test file with some links: The Microsoft Store and Spotify links should work, for a real example. The rest are used to see that the app name associated with the URI is correct. If no app is installed that handles the URI, or it's invalid, Windows will show the native message that no app is installed to handle the URI. The behavior should be the same when viewing .html, since the code is now in |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Changes
md2html.htmlfile to use relative file imports for better maintainability.<Quicklook data folder>/QuickLook.Plugin.MarkdownViewer/localStorageis now supported thanks to these changes.WebViewDefaultBackgroundColorto prevent white flash in dark mode. After the page has loaded, setsDefaultBackgroundColorback to white to have the expected default behavior on HTML pages that don't specify any background color.Clean up
jQuery.Screenshots
New:
Old:
