Change AllowDarkTheme handling #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n config file use dark background and light text (no syntax highlighting). With AllowDarkTheme disabled (default) use light background and light mode syntax highlighting.
|
Oops... thanks for the fix! |
|
Hi, it is still not possible to view text files in dark mode in the stable version 3.7.3, even after following the instructions here The dark mode for text files can only be seen with the latest nightly version of quicklook, but at this moment there is no artifact in appveyor to download, why not just add the nightly versions together with the stable version in this repository? It would be ideal since appveyor deletes artifacts older than one month automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1232
In Textviewer when OS is in dark mode and AllowDarkTheme is enabled in config file use dark background and light text (no syntax highlighting).
With AllowDarkTheme disabled (default) use light background and light mode syntax highlighting.