Handle multi-layer gimp xcf files. #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Does this issue happen also to Photoshop PSD files? |
xupefei
reviewed
Nov 29, 2022
| { | ||
| IMagickImage<byte> mi; | ||
| // Only flatten multi-layer gimp xcf files. | ||
| if (Path.LocalPath.EndsWith(".xcf") && layers.Count > 1) |
There was a problem hiding this comment.
@mooflu Ouch I shouldn't merge the PR so quickly -- this LocalPath should be lowercase before checking the EndsWith. Could you create a separate PR?
|
I believe a PSD file has an extra (first) layer that contains the flatted contents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.