Skip to content

Add translation possibility for missing buttons #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 25, 2023
Merged

Conversation

rabelux
Copy link
Member

@rabelux rabelux commented Mar 23, 2022

Hi @xupefei,
as users keep asking for translations I thought I'd give it a go.
I know python and matlab but unfortunately no c# so I need your input whether this goes in the right direction.
My changes weren't tested and I pushed these changes online.
Take your time if you're busy atm, I'm in no rush for having these translations.

@xupefei
Copy link
Member

xupefei commented Apr 1, 2022

Thanks @rabelux! Is this PR ready for review?

@rabelux rabelux marked this pull request as ready for review April 1, 2022 12:00
@rabelux
Copy link
Member Author

rabelux commented Apr 1, 2022

Sure, if you think what I did could work? 😄

@dracp
Copy link

dracp commented Apr 1, 2022

@rabelux
Add translation possibility for missing buttons pt2

Translation Spanish ES (Translations.config)

<UI_FontFamily>Segoe UI</UI_FontFamily>
<APP_START>QuickLook está funcionando en segundo plano.</APP_START>
<APP_SECOND>QuickLook ya está funcionando en segundo plano</APP_SECOND>
<APP_SECOND_TEXT>QuickLook permite la previsualización rápida de ciertos tipos de archivos pulsando la barra espaciadora mientras este está resaltado.</APP_SECOND_TEXT>
<APP_PATH_NOT_WRITABLE>No se puede escribir en la ruta "{0}". Por favor, compruebe si tiene suficientes permisos.</APP_PATH_NOT_WRITABLE>
<MW_StayTop>Siempre Encima</MW_StayTop>
<MW_PreventClosing>Evitar Cierre</MW_PreventClosing>
<MW_BrowseFolder>Explorar {0}</MW_BrowseFolder>
<MW_Open>Abrir {0}</MW_Open>
<MW_OpenWith>Abrir con {0}</MW_OpenWith>
<MW_OpenWithMenu>Abrir Con Menu</MW_OpenWithMenu>
<MW_Run>Iniciar {0}</MW_Run>
<MW_Share>Compartir</MW_Share>
<Icon_RunAtStartup>Iniciar con el &sistema</Icon_RunAtStartup>
<Icon_ToolTip>QuickLook v{0}</Icon_ToolTip>
<Icon_CheckUpdate>Buscar &Actualizaciones...</Icon_CheckUpdate>
<Icon_GetPlugin>Buscar nuevos &Plugins...</Icon_GetPlugin>
<Icon_Quit>&Salir</Icon_Quit>
<Update_NoUpdate>Está usando la última versión.</Update_NoUpdate>
<Update_Found>QuickLook {0} está disponible. Haga clic aquí para abrir la página de descarga.</Update_Found>
<Update_Error>Ocurrió un error al buscar actualizaciones: {0}</Update_Error>
<InfoPanel_LastModified>Última modificación el {0}</InfoPanel_LastModified>
<InfoPanel_DriveSize>Capacidad {0}, {1} disponible</InfoPanel_DriveSize>
<InfoPanel_Folder>{0} carpeta</InfoPanel_Folder>
<InfoPanel_Folders>{0} carpetas</InfoPanel_Folders>
<InfoPanel_File>{0} archivo</InfoPanel_File>
<InfoPanel_Files>{0} archivos</InfoPanel_Files>
<InfoPanel_FolderAndFile>({0} y {1})</InfoPanel_FolderAndFile>

@rabelux
Copy link
Member Author

rabelux commented Sep 6, 2022

@xupefei does my approach look good to you? Can this be merged?

@xupefei
Copy link
Member

xupefei commented Sep 8, 2022

Thanks for the PR!
We don't need to load translations on every preview, but once during window initialization, i.e., somewhere here: https://github.com/QL-Win/QuickLook/blob/master/QuickLook/ViewerWindow.xaml.cs#L99. Just make sure they come after InitializeComponent().

@xupefei
Copy link
Member

xupefei commented Nov 29, 2022

Hey @rabelux, any updates on this PR? After you change I want to contribute Chinese and Japanese translations to this PR 😀

@rabelux
Copy link
Member Author

rabelux commented Dec 10, 2022

Hi @xupefei, I'm really short on time at the moment and as I'm not really having a clue what I'm doing here, could you finish what I started? I think I allowed edits by maintainers for this PR.

@xupefei xupefei merged commit 431165f into master Mar 25, 2023
@xupefei xupefei deleted the missing-translations branch March 25, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants