Skip to content

Conversation

qtuantruong
Copy link
Member

Description

CPP files should be compiled from source PYX files depending on building environment for better compatibility. This also help clean up the repo and reduce codebase significantly.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

Copy link
Member

@lthoang lthoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qtuantruong qtuantruong merged commit 850c5c7 into PreferredAI:master Oct 25, 2023
@qtuantruong qtuantruong deleted the clean-cpp-files branch October 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants