Skip to content

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Jan 17, 2024

Description

Related Issues

#585

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@lthoang lthoang requested review from darrylong, qtuantruong and hieuddo and removed request for darrylong January 17, 2024 06:04
@qtuantruong
Copy link
Member

Let's keep this open for awhile

@qtuantruong qtuantruong self-assigned this Jan 17, 2024
@qtuantruong qtuantruong added the feature New feature/enhancement request label Jan 17, 2024
@qtuantruong qtuantruong requested a review from saghiles January 17, 2024 18:52
@qtuantruong
Copy link
Member

I've tried to provide keywords that best describe the model type/family. If anyone has a better idea, please feel free to contribute.

@darrylong
Copy link
Member

Was thinking as this is a long table with many columns, it could be a bit overwhelming.

Ideally we could have a sort feature (by year vs by model type) on this table. But upon checking, I think that is a limitation of MD files.

Just throwing a few possibilities:

  1. Create another "models.md" readme file to sort by model type. (more maintenance required)
  2. Split this table into smaller tables based on categories (longer readme.md file)
  3. Keep it as it is. I think the current table serves its purpose if generally users only care about using the most recent models.

Thanks everyone! :)

@darrylong darrylong changed the title Add colunm model type into table models Add column model type into table models Jan 18, 2024
@qtuantruong
Copy link
Member

Was thinking as this is a long table with many columns, it could be a bit overwhelming.

Ideally we could have a sort feature (by year vs by model type) on this table. But upon checking, I think that is a limitation of MD files.

Just throwing a few possibilities:

  1. Create another "models.md" readme file to sort by model type. (more maintenance required)
  2. Split this table into smaller tables based on categories (longer readme.md file)
  3. Keep it as it is. I think the current table serves its purpose if generally users only care about using the most recent models.

Thanks everyone! :)

Agree that the current table is a bit long, though splitting into multiple tables will make things look very fragmented. Also, certain categories contain more models than others. I think it's best to keep one table for now until we find a better solution. I'm also thinking about experimenting with html table in markdown but not sure how much GitHub can render it.

@qtuantruong qtuantruong self-requested a review January 22, 2024 02:19
@qtuantruong
Copy link
Member

In case no one is having any idea, we can merge this PR the next day. @lthoang

@lthoang lthoang merged commit 92a94e3 into PreferredAI:master Jan 24, 2024
@lthoang lthoang deleted the model-type branch January 24, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants