Skip to content

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Dec 28, 2023

Description

This is an adaptation of an official implementation of GRU4Rec.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@qtuantruong qtuantruong added feature New feature/enhancement request models New models, changes to models labels Dec 29, 2023
@qtuantruong
Copy link
Member

@lthoang please also consider adding model into the docs

@lthoang lthoang requested a review from qtuantruong December 30, 2023 03:58
@qtuantruong
Copy link
Member

LGTM

@qtuantruong
Copy link
Member

@lthoang @hieuddo just curious whether we obtain comparable results to the original implementation on the same dataset?

@lthoang
Copy link
Member Author

lthoang commented Jan 4, 2024

@lthoang @hieuddo just curious whether we obtain comparable results to the original implementation on the same dataset?

To be able to compare with original implementation, we need to further add an evaluation option for evaluating every next item in test sequence.
I have mentioned in #543 (comment)

@tqtg Should we also include that in this PR, or create a separate PR?

@qtuantruong
Copy link
Member

@lthoang let have this merged and we can work on another PR for that evaluation feature

@lthoang lthoang merged commit 031f32b into PreferredAI:master Jan 5, 2024
@lthoang lthoang deleted the gru4rec branch January 5, 2024 01:27
@darrylong darrylong removed the feature New feature/enhancement request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models New models, changes to models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants