Skip to content

Rename symbols to ensure consistency #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

Rename symbols to ensure consistency #565

merged 2 commits into from
Dec 12, 2023

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Dec 9, 2023

Description

Refactor naming basket_ids to basket_indices and create another basket_ids property in BasketDataset class.

This naming convention is consistent with user_ids and item_ids in Dataset class.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@qtuantruong
Copy link
Member

LGTM

@lthoang lthoang merged commit e54190f into PreferredAI:master Dec 12, 2023
@lthoang lthoang deleted the nbr-refactor branch December 12, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qtuantruong qtuantruong qtuantruong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lthoang @qtuantruong