Feature: Worker type selection and base job template configuration in worker pool create form #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 21, 2023 10:09
…brary into workers-field
✅ Deploy Preview for prefect-ui-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 11 commits
February 23, 2023 10:26
…r the base job template
Co-authored-by: Nicholas Brown <znicholasbrown@gmail.com>
Co-authored-by: pleek91 <craig@prefect.io>
Co-authored-by: pleek91 <craig@prefect.io>
Feature: Adds display of base job configuration details for work pool
Feature: Update work pool edit form to allow updates to the default values for the base job template
znicholasbrown
approved these changes
Feb 28, 2023
pleek91
reviewed
Feb 28, 2023
Comment on lines
+70
to
+75
| const schema = computed<Schema>(() => mapper.map('SchemaResponse', baseJobConfigs.value.variables ?? {}, 'Schema')) | ||
| const parameters = ref() | ||
|
|
||
| const testSchema = computed<Schema>(() => { | ||
| return { ...schema.value, type: 'object' } | ||
| }) |
There was a problem hiding this comment.
@desertaxle just calling out that this testSchema was for debugging. I couldn't figure out why the schema wasn't rendering and turned out to be because the schema fields component was expecting the object type. Not sure if that's a bug in the schemes themselves being used here or if the component should know that anything with properties is an object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to define the type for a work pool and the default values for a work pool's base job template when creating a work pool. The available worker types and default base job templates are retrieved from the collection registry and the
variablessection is used to render a schema-based form. The values entered in the form are used to update thedefaultkey for each property in thevariablessection of the default base job template and the full schema is saved to the work pool via the API.Screenshot of form for the
Processworker typeAdditional changes to be addressed in subsequent PRs: