Add kill kubernetes method #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

zanieb merged 11 commits into feature/flow-run-cancellation from kill-kubernetes

Dec 1, 2022

Contributor

peytonrunyan commented Nov 30, 2022 •

edited by zanieb

Loading

This pull request add the kill method for the KubernetesJob infrastructure block.

As part of this, taskgroup.started() is now called with a job_pid instead of a job_name. The job_pid is <cluster_name>:<job_name>.

Part of #7666

peytonrunyan marked this pull request as ready for review

November 30, 2022 23:53

peytonrunyan requested a review from zanieb as a code owner

November 30, 2022 23:53

peytonrunyan added enhancement v2 and removed enhancement v2 labels

peytonrunyan requested a review from bunchesofdonald

December 1, 2022 00:06

peytonrunyan added 3 commits

November 30, 2022 19:24


          add kill to kubernetes

83d022b


          existing tests work

425d3bd


          add tests

b4ab970

zanieb force-pushed the kill-kubernetes branch from 435bd54 to b4ab970 Compare

December 1, 2022 01:25

zanieb reviewed

View reviewed changes

src/prefect/infrastructure/kubernetes.py Outdated Show resolved Hide resolved

zanieb reviewed

View reviewed changes

src/prefect/infrastructure/kubernetes.py Outdated Show resolved Hide resolved

zanieb reviewed

View reviewed changes

src/prefect/infrastructure/kubernetes.py Outdated Show resolved Hide resolved

zanieb reviewed

View reviewed changes

tests/infrastructure/test_kubernetes_job.py Outdated Show resolved Hide resolved

zanieb reviewed

View reviewed changes

src/prefect/infrastructure/kubernetes.py Show resolved Hide resolved

zanieb reviewed

View reviewed changes

src/prefect/infrastructure/kubernetes.py Outdated Show resolved Hide resolved

zanieb mentioned this pull request

Tracking: Flow run cancellation #7666

Merged

bunchesofdonald approved these changes

View reviewed changes

tests/infrastructure/test_kubernetes_job.py Outdated Show resolved Hide resolved

peytonrunyan added 8 commits

December 1, 2022 10:19


          rename get_cluster_name -> get_active_cluster_name

2dc839a


          rename _set_config -> _configure_kubernetes_library_client

9e85611


          update docstring for configure_k8s_lib_client

122a9ea


          update test error code

bc315e5


          update to use assert_called_once_with

cdc0673


          explain importance of Foreground prop policy

aa13abf


          chain exceptions

f91c1fb


          fix formatting issue

7f75305

zanieb merged commit bc12401 into feature/flow-run-cancellation

zanieb deleted the kill-kubernetes branch

December 1, 2022 16:52

zanieb pushed a commit that referenced this pull request


          Add kill kubernetes method (#7701)

30f0eb3

zanieb pushed a commit that referenced this pull request


          Add kill kubernetes method (#7701)

a9d0ad8

github-actions bot pushed a commit that referenced this pull request


          Add kill kubernetes method (#7701)

308937c

zanieb mentioned this pull request

Use cluster uid and namespace instead of cluster "name" for Kubernetes job identifiers #7747

Merged

3 tasks

github-actions bot pushed a commit to ddelange/prefect that referenced this pull request


          Add kill kubernetes method (PrefectHQ#7701)

0c4bf17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet