Add flow run cancel command #7629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
We probably shouldn't merge this until cancellation is available. |
bunchesofdonald
approved these changes
Nov 22, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Dec 1, 2022
zanieb
pushed a commit
that referenced
this pull request
Dec 1, 2022
github-actions bot
pushed a commit
to ddelange/prefect
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the command
prefect flow-run cancel <run_id>.This CLI command will change the
state.StateTypeof a given flow run toCANCELLEDand the state name toCancellingif possible, and otherwise will exit with error saying that it could not be cancelled. If it could not cancel, it will provide the reason from the abort status.There is also a change in the orion client, which changes
set_flow_run_stateto raiseObjectNotFoundif we get a 404. This brings it in-line with the behavior of the rest of the functions in the orion client. A test has been added for this.Example
Checklist
<link to issue>"fix,feature,enhancement