Add cancel button to the flow run page in the UI #7672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
approved these changes
Nov 28, 2022
|
@marichka-offen You can treat this as if it's going into main, we generally won't do another code review when we merge the tracking branch. |
|
@madkinsz I'll merge this PR to give you a Cancel button in UI, but there's a little gotcha. Because the way we do it is literally a hack to accommodate the absence of feature flags in orion, the Cancel button takes 30 seconds to disappear from UI once the state is changed to Cancelling. Once the active work on this feature is done and we are ready to show it to user, I will add the button the regular way we do it in orion-design (without using a slot). That way button will be removed from UI immediately |
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Nov 30, 2022
zanieb
pushed a commit
that referenced
this pull request
Dec 1, 2022
zanieb
pushed a commit
that referenced
this pull request
Dec 1, 2022
github-actions bot
pushed a commit
to ddelange/prefect
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7666
This PR makes Cancel button available for feature/flow-run-cancellation
Example
Checklist
<link to issue>"fix,feature,enhancement