Skip to content

Tracking: Flow run cancellation #7666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 1, 2022
Merged

Tracking: Flow run cancellation #7666

merged 8 commits into from
Dec 1, 2022

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Nov 28, 2022 •
edited
Loading

@zanieb zanieb added the feature A new feature label Nov 28, 2022
@netlify
Copy link

netlify bot commented Nov 28, 2022 •
edited
Loading

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit bcbaa88
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/6388f636a3c9db0008963307
😎 Deploy Preview https://deploy-preview-7666--prefect-orion.netlify.app/api-ref/prefect/infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb zanieb mentioned this pull request Nov 28, 2022
Closed
3 tasks
@zanieb zanieb force-pushed the feature/flow-run-cancellation branch from e2bbe58 to 886f129 Compare November 28, 2022 22:08
@zanieb zanieb mentioned this pull request Nov 28, 2022
Merged
3 tasks
@zanieb zanieb force-pushed the feature/flow-run-cancellation branch 4 times, most recently from e3caa3f to d5e6209 Compare November 30, 2022 19:59
@zanieb zanieb mentioned this pull request Nov 30, 2022
Merged
2 tasks
@ahuang11 ahuang11 mentioned this pull request Nov 30, 2022
Merged
3 tasks
This was referenced Dec 1, 2022
Merged
Merged
@rpeden rpeden mentioned this pull request Dec 1, 2022
Merged
3 tasks
@zanieb zanieb marked this pull request as ready for review December 1, 2022 18:21
@zanieb zanieb requested a review from pleek91 as a code owner December 1, 2022 18:21
@zanieb zanieb force-pushed the feature/flow-run-cancellation branch from bc12401 to 30f0eb3 Compare December 1, 2022 18:22
bunchesofdonald
bunchesofdonald approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@peytonrunyan peytonrunyan self-requested a review December 1, 2022 18:27
peytonrunyan
peytonrunyan approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@peytonrunyan peytonrunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 1, 2022
View reviewed changes
src/prefect/agent.py

result = fn(*args, **kwargs)
if inspect.iscoroutine(result):
await result

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
ahuang11
ahuang11 reviewed Dec 1, 2022
View reviewed changes
ahuang11
ahuang11 reviewed Dec 1, 2022
View reviewed changes
@zanieb zanieb merged commit 95f3cbf into main Dec 1, 2022
@zanieb zanieb deleted the feature/flow-run-cancellation branch December 1, 2022 18:59
@zanieb zanieb mentioned this pull request Dec 1, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bunchesofdonald bunchesofdonald bunchesofdonald approved these changes

@pleek91 pleek91 Awaiting requested review from pleek91

+2 more reviewers

@ahuang11 ahuang11 ahuang11 left review comments

@peytonrunyan peytonrunyan peytonrunyan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zanieb @bunchesofdonald @ahuang11 @peytonrunyan @marichka-offen