Fix built-in resource and settings discovery when dsc is invoked using a symlink #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| Err(DscError::NotSupported("Can't get the path to dsc executable".to_string())) |
There was a problem hiding this comment.
The error message could be more informative. Consider including the specific error encountered.
Suggested change
| Err(DscError::NotSupported("Can't get the path to dsc executable".to_string())) | |
| Err(DscError::NotSupported(format!("Can't get the path to dsc executable: {}", env::current_exe().unwrap_err()))) |
Copilot uses AI. Check for mistakes.
SteveL-MSFT
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #618
Winget creates a symlink at its own location
C:\Users\Andrew\AppData\Local\Microsoft\WinGet\Linksand adds that to the PATH instead of the real target, so built-in resources/settings discovery finds nothing.This PR updates code to use the target path if invoked
dsc.exeis a symlink.Fix verified on a Winget deployment of DSC.