Ensure systemRoot() always has trailing separator character
#616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgauth
reviewed
Dec 16, 2024
adityapatwardhan
requested changes
Dec 16, 2024
path() function where first arg is a drive letter to add separatorsystemRoot() always has trailing separator character
tgauth
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Change so that
systemRoot()always includes a trailing separator. This is due to howPathBuf.push()works on Windows vs non-Windows andpath()adopts this behavior:c:andwindows, you getc:windowswhich is a relative path to the currentc:drive location'a', 'c:', 'b'will bec:b, you would usec:\to make sure it's absoluteAdded extra tests to
path()that aren't needed for this PR, but good to have.