fix(ingestion): escape surrogate characters when producing to kafka #9368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tiina303
approved these changes
Apr 8, 2022
Co-authored-by: Tiina Turban <tiina303@gmail.com>
yakkomajuri
commented
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem we have as posted on Slack:
The approach I took here was to follow what was done here: fastify/fast-json-stringify#151
That means escaping all surrogates, rather than trying to look for surrogates without a pair. It's a valid tradeoff.
Once impletmented in JS I then made sure Python had the same functionality.
Has tests for both sides