feat(session-recording): store session recording data outside of ClickHouse #9294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
I'm thinking the order of changes is:
(what am I missing/getting wrong :)) |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to 2 weeks of inactivity. Feel free to reopen it if still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A high proportion of ClickHouse disk space is dedicated to session recordings. These disks are expensive and ClickHouse isn't needed to query the payload data that is using up the space
see #2142
Changes
How does it work?
sequenceDiagram actor web actor SDK actor app.posthog.com actor kafka actor plugin.server actor clickhouse actor object_storage SDK->>app.posthog.com: session_recording_event app.posthog.com->>kafka: chunked_session_recording_events kafka->>+plugin.server: plugin.server->>clickhouse: stores chunks without data plugin.server->>-object_storage: stores chunk data web->>+app.posthog.com: load session data app.posthog.com->>clickhouse: load session json loop for every loaded chunk app.posthog.com->>object_storage: load chunk data for session json end app.posthog.com->>-web: return session dataHow did you test this code?
running it locally, adding some tests
## consequences
storage becomes mandatory for self-host
Do we support both? Or make it super easy to use storage
We'll need storage for:
Related PRs