chore: Fix snapshots on master #9885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
commented
May 20, 2022
| @@ -1275,7 +1275,7 @@ | |||
| WHERE team_id = 2 | |||
| AND (event = '$pageview') | |||
| AND timestamp >= toDateTime('2012-01-01 00:00:00') | |||
| AND timestamp <= toDateTime('2012-01-02 23:59:59') | |||
There was a problem hiding this comment.
@timgl , looks like there's some differences between CH version 21.11 (on which snapshot tests ran on your PR) and 22.3 (which is the new default).
Just FYI. I'm not yet sure how these changes could've happened, but will investigate if you don't end up getting to it
neilkakkar
commented
May 20, 2022
macobo
approved these changes
May 20, 2022
fuziontech
added a commit
that referenced
this pull request
May 20, 2022
* master: chore: start stack once in cloud tests (#9879) feat(apps): frontend apps (#9831) chore: Fix snapshots on master (#9885) chore(apps): rename plugins to apps (#9755) refactor: Remove constance library dependency, use json-encoded model (#9852) chore(clickhouse): avoid creating kafka_events, events_mv (#9863) fix(insights): Fix timezone date issues (#9678) refactor(plugin-server): refactor the event pipeline (#9829) feat(object storage): add unused object storage (#9846) fix: make kafka health check timeout test reliable (#9857) fix: query elements from start of day (#9827)
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running snapshot tests on master.
Change ramifications to follow up here: #9678 - but atleast this PR unblocks others from having their tests keep failing and updating and rerunning
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?