Skip to content

feat(lifecycle): Lifecycle persons on events #9880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 13, 2022
Merged

feat(lifecycle): Lifecycle persons on events #9880

merged 5 commits into from
Jul 13, 2022

Conversation

neilkakkar
Copy link
Contributor

@neilkakkar neilkakkar commented May 20, 2022 •
edited
Loading

Problem

Enabling person on events for lifecycle

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@neilkakkar neilkakkar mentioned this pull request May 25, 2022
Closed
19 tasks
@neilkakkar neilkakkar changed the title WIP - pending schema update - Lifecycle person events feat(lifecycle): pending schema update - Lifecycle person events May 26, 2022
@neilkakkar neilkakkar force-pushed the lifecycle-person-events branch from 12ce5bf to afcc436 Compare May 26, 2022 11:41
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to 2 weeks of inactivity. Feel free to reopen it if still relevant.

@neilkakkar neilkakkar reopened this Jun 10, 2022
@posthog-bot posthog-bot removed the stale label Jun 13, 2022
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to 2 weeks of inactivity. Feel free to reopen it if still relevant.

@neilkakkar neilkakkar reopened this Jun 28, 2022
@posthog-bot posthog-bot removed the stale label Jun 29, 2022
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@neilkakkar neilkakkar requested a review from EDsCODE July 11, 2022 12:00
@neilkakkar neilkakkar marked this pull request as ready for review July 11, 2022 12:03
@neilkakkar neilkakkar changed the title feat(lifecycle): pending schema update - Lifecycle person events feat(lifecycle): Lifecycle persons on events Jul 11, 2022
@neilkakkar neilkakkar enabled auto-merge (squash) July 13, 2022 10:45
@neilkakkar neilkakkar merged commit fce8548 into master Jul 13, 2022
@neilkakkar neilkakkar deleted the lifecycle-person-events branch July 13, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilkakkar @posthog-bot @EDsCODE