fix(onboarding): instrumentation #9845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmarron
commented
May 18, 2022
| @@ -681,10 +685,27 @@ describe('eventsTableLogic', () => { | |||
| }) | |||
|
|
|||
| it('fires two actions to change state, but just one API.get', async () => { | |||
There was a problem hiding this comment.
This test previously wasn't waiting for the fetchEventsSuccess action, so we were checking how many api calls were made before api calls were made. The one that was be counted was from the mount function.
The changes below clean this up.
rcmarron
commented
May 18, 2022
| if (preflight) { | ||
| actions.loadPreflightSuccess(preflight) | ||
| } else if (!values.preflight) { | ||
| actions.loadPreflight() | ||
| } | ||
| if (switchedTeam) { |
There was a problem hiding this comment.
Moved this to teamLogic to decouple things
liyiy
approved these changes
May 18, 2022
neilkakkar
approved these changes
May 19, 2022
fuziontech
added a commit
that referenced
this pull request
May 19, 2022
* master: refactor(ingestion): Make `KAFKA_ENABLED` true by default and set `KAFKA_HOSTS` default (#9844) feat(apps): transpile frontend.tsx (#9828) feat: show api call status when adding insights to dashboards (#9817) feat: track metrics on zapier hook firings (#9866) fix(onboarding): instrumentation (#9845) feat(whitelabel-shared-dashboard): Hide branding on shared dashboards paid (#9849) fix(apps): plugin source quickfix (#9862) refactor(plugin-server): Remove `ts-jest`, use `jest.mocked` (#9861) refactor(plugin-server): Trigger public jobs with graphile insted of celery queue (#9811) chore: upgrade pip tools (#9859) feat(apps): plugin source in its own model, part 2 (#9854) chore: Update sprint_planning_retro.md (#9791) feat(apps): plugin source in its own model, part 1 (#9853) feat(matrix): Add option to save `simulate_matrix` like `setup_dev` (#9836) fix(cohort): add mapping from event to person (#9841) feat(person-on-events): Enable CI to run using both old and new queries (#9814)
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For onboarding, we want to have instrumentation for when a user starts ingesting events. Because experimentation only works in posthog-js, we need to fire this event from the front-end. Originally, it fired from the homepage logic, but the issue is that not everyone visits the homepage after ingesting events.
Changes
This PR:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Verified the event fires and we don't hit circular dependency issues.