feat(matrix): Add option to save simulate_matrix like setup_dev
#9836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
approved these changes
May 18, 2022
There was a problem hiding this comment.
Cool stuff!
I ran into a tricky issue though: after I made my user, I logged in, but the plugin server hadn't caught up and the charts rendered blank. For example there were no countries on the map. Only after a reload did something show up.
Not sure what can be done about that, other than directing the user to the live events view as the first thing to show what to expect 🤔
|
Hmm, I think the map issue might have been that |
fuziontech
added a commit
that referenced
this pull request
May 19, 2022
* master: refactor(ingestion): Make `KAFKA_ENABLED` true by default and set `KAFKA_HOSTS` default (#9844) feat(apps): transpile frontend.tsx (#9828) feat: show api call status when adding insights to dashboards (#9817) feat: track metrics on zapier hook firings (#9866) fix(onboarding): instrumentation (#9845) feat(whitelabel-shared-dashboard): Hide branding on shared dashboards paid (#9849) fix(apps): plugin source quickfix (#9862) refactor(plugin-server): Remove `ts-jest`, use `jest.mocked` (#9861) refactor(plugin-server): Trigger public jobs with graphile insted of celery queue (#9811) chore: upgrade pip tools (#9859) feat(apps): plugin source in its own model, part 2 (#9854) chore: Update sprint_planning_retro.md (#9791) feat(apps): plugin source in its own model, part 1 (#9853) feat(matrix): Add option to save `simulate_matrix` like `setup_dev` (#9836) fix(cohort): add mapping from event to person (#9841) feat(person-on-events): Enable CI to run using both old and new queries (#9814)
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
…9836) * feat(matrix): Add option to save `simulate_matrix` like `setup_dev` * Fix signups map * Improve handling of error and success with `--save-as`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#7889 added
manage.pycommandsimulate_matrix, which simulates users of a product and prints output. There was no way to save that output to the DB however.Changes
This makes all
simulate_matrixarguments optional and adds a new one:--save-as, which is the email of the account that should be created to save the output. The password is 12345678.Also refactored datetimes to be timezone-aware so that Django doesn't complain.
This kind of makes
setup_devdeprecated, but it's used in E2E tests, so not removing here.How did you test this code?
Ran
DEBUG=1 ./manage.py simulate_matrix --save-as michael@posthog.com