fix: exclusion steps cannot be selected #9762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perhaps makes sense to update the frontend to not send that API request? Since that's atleast one extra query making it to Clickhouse which is worthless. And on the backend, filtering out empty entities, but not incomplete ones as the current solution does, as that hides better error messages / covers a larger error area than we want |
|
Also, fixes #9537 |
benjackwhite
approved these changes
May 13, 2022
@benjackwhite that makes two of us 🤣 the joy of support week fixes is a kind of freedom |
3 tasks
fuziontech
added a commit
that referenced
this pull request
May 13, 2022
* master: fix: exclusion steps cannot be selected (#9762) feat(lemon-button): Support `status` for `primary` buttons (#9782) fix: healthcheck for kafka on plugin server (#9771) fix(billing): Update billing success message (#9739) fix(plugin-server): Set transpileOnly when importing piscina code in tests (#9777) fix(plugin-server): Remove unused kafka reset test code (#9779) fix: set kafka_skip_broken_messages on dead letter queue table (#9754) fix(plugin-server): remove dead code from worker.test.ts (#9776) refactor(plugin-server): Run ingestion only on worker threads (#9738) fix: Plugin-server tests with kafka need to have consumer stopped (#9774) chore(deps): Update posthog-js to 1.21.1 (#9773) chore(dep): upgrading rr-web (#9772) fix: ouroboros inputs (#9769)
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
* don't error if sent an empty exclusion, just ignore it * strongly opinionated get it working * only filter out empty dictionaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In this community slack message the user reports that when they try to add an exclusion filter to a funnel they get an error.
Confirmed this happens for all users
The error is because on adding the exclusion filter, and before being offered a pop-up to choose the event or action, the UI sends an empty exclusion filter to the API
Fixing the API to ignore those empty values shows that the exclusion filter UI does not allow you to make a selection. So exclusion filters cannot be added.
Changes
in order to get the feature functionally working again
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
running it locally