fix: make cohort name field error consistent #9744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkus
suggested changes
May 11, 2022
There was a problem hiding this comment.
Looks good - just noticed that we could update the error content to be a bit more clear and less about the user. Instead of saying:
Error: you need to set a name
We could say something like:
Cohort name cannot be empty
It just makes it more about the required field and less about what the user did.
clarkus
approved these changes
May 11, 2022
fuziontech
added a commit
that referenced
this pull request
May 12, 2022
* master: fix(cohorts): num comparison (#9764) fix(trends): Use 0 as fallback data point value (#9766) fix: Flexing of PropertyFilterButton (#9761) chore(funnels): Add `lemon-funnel-viz` to `PERSISTED_FEATURE_FLAGS` (#9757) feat(insights): New and improved ActionFilter (#9741) fix: make the kafka inspector work again after kea-forms update (#9758) fix: repace underscores with spaces in the cloud announcement (#9751) chore(contributors): 🤖 - Add utkuzih as a contributor 🎉 (#9748) fix: cohort person property value not populated (#9745) fix: make cohort name field error consistent (#9744) fix(cohort): don't let time_value be less than 0 (#9742)
alexkim205
added a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://posthog.slack.com/archives/C034XD440RK/p1652294642784479
Changes
Before
After
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
con mi ojos