Allow overriding kafka host for clickhouse via KAFKA_URL_CLICKHOUSE env var #8332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9e03b6 to
e7575d7
Compare
…nv var This is needed when using an external clickhouse which doesn't have the same access to kafka as in-cluster traffic does. Note that long-term we might need to also provide better auth mechanisms here as well.
e7575d7 to
6ea6590
Compare
posthog/settings/data_stores.py
Outdated
| KAFKA_HOSTS = _parse_kafka_hosts(KAFKA_URL) | ||
|
|
||
| # Kafka broker host(s) that is used by clickhouse for ingesting messages. Useful if clickhouse is hosted outside the cluster. | ||
| KAFKA_HOSTS_CLICKHOUSE = _parse_kafka_hosts(os.getenv("KAFKA_URL_CLICKHOUSE", KAFKA_URL)) |
There was a problem hiding this comment.
What about KAFKA_URL_EXTERNAL?
There was a problem hiding this comment.
Not used anywhere hence thought best not to expose it.
There was a problem hiding this comment.
From discussion: KAFKA_HOSTS_FOR_CLICKHOUSE and similar name for the env var :)
guidoiaquinti
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when using an external clickhouse which doesn't have the
same access to kafka as in-cluster traffic does.
Note that long-term we might need to also provide better auth mechanisms
here as well.
Related: PostHog/charts-clickhouse#276