Skip to content

Fix inefficient and erroneous insight cache updating #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 9, 2021
Merged

Fix inefficient and erroneous insight cache updating #5051

merged 5 commits into from
Jul 9, 2021

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jul 8, 2021

Changes

Resolves #5025.

Checklist

  • Django backend tests

@Twixes Twixes requested review from paolodamico and EDsCODE July 8, 2021 22:22
@timgl timgl temporarily deployed to posthog-pr-5051 July 8, 2021 22:25 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-5051 July 8, 2021 22:29 Inactive
@Twixes Twixes requested a review from neilkakkar July 8, 2021 22:35
@Twixes Twixes temporarily deployed to posthog-pr-5051 July 8, 2021 22:35 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-5051 July 8, 2021 22:46 Inactive
@Twixes Twixes mentioned this pull request Jul 8, 2021
Closed
paolodamico
paolodamico approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolodamico paolodamico merged commit a76959b into master Jul 9, 2021
@paolodamico paolodamico deleted the fix-insight-update-cache branch July 9, 2021 00:03
@neilkakkar neilkakkar mentioned this pull request Jul 30, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

1 more reviewer

@paolodamico paolodamico paolodamico approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'posthog.queries.sessions' has no attribute 'Sessions'
3 participants
@Twixes @paolodamico @timgl