Skip to content

Make local events table work with proto from kafka #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2020
Merged

Make local events table work with proto from kafka #2254

merged 1 commit into from
Nov 7, 2020

Conversation

fuziontech
Copy link
Member

Changes

Please describe.
If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-localproto-j9bkbx2j9xo November 6, 2020 01:06 Inactive
@timgl
Copy link
Collaborator

timgl commented Nov 6, 2020

I'm getting this error locally now when posting an event to /e/

web_1         | Traceback (most recent call last):
web_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner
web_1         |     response = get_response(request)
web_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response
web_1         |     response = self.process_exception_by_middleware(e, request)
web_1         |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
web_1         |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
web_1         |   File "/usr/local/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
web_1         |     return view_func(*args, **kwargs)
web_1         |   File "/code/posthog/api/capture.py", line 169, in get_event
web_1         |     process_event_ee(
web_1         |   File "/code/ee/clickhouse/process_event.py", line 127, in process_event_ee
web_1         |     create_session_recording_event(
web_1         |   File "/code/ee/clickhouse/models/session_recording_event.py", line 34, in create_session_recording_event
web_1         |     p = ClickhouseProducer()
web_1         |   File "/code/ee/kafka_client/client.py", line 58, in __init__
web_1         |     self.producer = KafkaProducer()
web_1         |   File "/code/posthog/utils.py", line 360, in __call__
web_1         |     self.instance = self.klass(*args, **kwds)
web_1         |   File "/code/ee/kafka_client/client.py", line 32, in __init__
web_1         |     self.producer = KP(bootstrap_servers=KAFKA_HOSTS)
web_1         |   File "/usr/local/lib/python3.8/site-packages/kafka/producer/kafka.py", line 380, in __init__
web_1         |     client = KafkaClient(metrics=self._metrics, metric_group_prefix='producer',
web_1         |   File "/usr/local/lib/python3.8/site-packages/kafka/client_async.py", line 242, in __init__
web_1         |     self.config['api_version'] = self.check_version(timeout=check_timeout)
web_1         |   File "/usr/local/lib/python3.8/site-packages/kafka/client_async.py", line 898, in check_version
web_1         |     raise Errors.NoBrokersAvailable()
web_1         | kafka.errors.NoBrokersAvailable: NoBrokersAvailable

@fuziontech
Copy link
Member Author

Sounds like Kafka is down. Have you tried restarting the docker-compose stack?

@fuziontech
Copy link
Member Author

This pr is all clickhouse side. it shouldn't have changed anything on the producer side where your error is.

@fuziontech fuziontech merged commit ccd70fa into master Nov 7, 2020
@fuziontech fuziontech deleted the localproto branch November 7, 2020 01:15
@macobo macobo mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuziontech @timgl