style: Replace Ant icons with Lemon ones #13738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, before this PR we weren't actually showing pay gates for correlation analysis upselling, due to what looks like a bug (line of code). So users on free plans weren't informed such a feature exists. @neilkakkar Can you confirm whether this visual diff (with a pay gate once again) look right to you: https://github.com/PostHog/posthog/pull/13738/files#diff-5a0b5d67b76751e047e19279eddcf830288393eb8a54e8d0a4db1aaed880915b? |
|
Thanks for catching, yep looks good! |
59 tasks
pauldambra
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is part 1 of probably 3 PRs replacing Ant icons with Lemon ones. Only targeting isolated cases of those icons here – those embedded in other Ant components such as
Selectwill be replaced when those components are refactored away. Also skipping the Toolbar here (leaving that for the third PR in the series).This also reduces usage of two components targeted for removal:
InlineMessage(redundant because ofAlertMessage) andPayCard(redundant because ofPayGateMini). Completely removes two completely redundant components:SelectDownIconandCohortIcon.How did you test this code?
I reviewed every single case manually, but we don't have visual regression tests for almost any of them, and it'd be a massive effort to add them in this PR, so take a look locally too.