Skip to content

feat(hogql): nullish coalescing #16276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

feat(hogql): nullish coalescing #16276

merged 1 commit into from
Jun 28, 2023

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jun 27, 2023 •
edited
Loading

Problem

Typing ifNull(bla, 0) everywhere is cumbersome. I'm used to so much better from TypeScript.

Changes

Adds ??, so instead of

select length(JSONExtractArrayRaw(ifNull(properties.$active_feature_flags, '[]'))) from events limit 1

you can do

select length(JSONExtractArrayRaw(properties.$active_feature_flags ?? '[]')) from events limit 1

How did you test this code?

I took care to have the operator precedence match what JS does. So 1 + null ?? 2 + 3 translates to (1 + null) ?? (2 + 3), and not 1 + (null ?? 2) + 3.

@mariusandra mariusandra requested review from thmsobrmlr and Twixes June 27, 2023 23:20
@mariusandra mariusandra mentioned this pull request Jun 27, 2023
Open
Twixes
Twixes approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice

@mariusandra mariusandra merged commit 63d6abe into master Jun 28, 2023
@mariusandra mariusandra deleted the nullish branch June 28, 2023 07:49
This was referenced Jun 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@thmsobrmlr thmsobrmlr Awaiting requested review from thmsobrmlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @Twixes