feat(hogql): property array access #15965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PostHog I love subscribing to issues and know that a feature we need is going to be implemented <3 @jannesblobel subscribe to this issue. When this issue is complete we can build insights to derive what plugins are used. |
|
Haha, great to hear! There are a few more complex cases I still need to get working before it's ready. Unlikely this will be done, reviewed and merged today, but soon 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
You can't access array elements in properties
Changes
Makes the following cases work:
properties.stringproperties.array_str.1properties.array_str[1]properties.obj_array.id.1properties.obj_array.id[1]properties.array_array_str.1.1properties.array_array_str[1][1]properties.array_obj_array.1.id.1properties.array_obj_array[1]['id'][1]properties.array_obj_array_obj.1.id.1.idproperties.array_obj_array_obj[1].id[1].idproperties.array_obj_array_obj[1]['id'][1]['id']properties.array_obj.1.idproperties.array_obj[1].idSadly for all of us, SQL indexes start from
1. This is bound to cause confusion, so I added a helpful error if you use0.SQL indexes can also be negative, so we can't automatically
+1in the HogQL layer either 🙃How did you test this code?
Plenty of test changes. Tried it in the UI as well.
Out of scope
We could fork ClickHouse