Skip to content

feat(hogql): tuple access #15130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Apr 18, 2023
Merged

feat(hogql): tuple access #15130

merged 30 commits into from
Apr 18, 2023
+70 −2

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Apr 18, 2023 •
edited
Loading

Problem

Makes operating some array functions nicer possible.

Changes

  • something.0 where 0 matches[0-9+] now is considered "tuple access", just like in ClickHouse.
  • We print this out accordingly.
  • This syntax used to error. Use backticks for strings.
  • Adds two new aggregations. These help with running a real world query in the tests. More aggregations coming in another PR.
  • Side effect: makes pivot tables possible

How did you test this code?

  • Added a real world test (pivot tables)

@mariusandra mariusandra requested a review from a team April 18, 2023 10:34
Twixes
Twixes approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Twixes Twixes force-pushed the hogql-types-improved branch from 2841a55 to 0136a50 Compare April 18, 2023 14:04
@mariusandra mariusandra mentioned this pull request Apr 18, 2023
Open
Base automatically changed from hogql-types-improved to master April 18, 2023 20:21
@mariusandra mariusandra merged commit 2921ebb into master Apr 18, 2023
@mariusandra mariusandra deleted the hogql-tuple-access-enabled branch April 18, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @Twixes