-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(hogql): add poe v2 support #15120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mariusandra any thoughts? |
It took a few stacked PRs of refactors, but I got a more or less clean version of custom sql fields ready. It's still a draft and I'm actively watering its prerequisite. So soon, soon. However you can rebase and play with it. It should fit into the PoEv2 system nicely, though I didn't try it yet myself. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Not stale. Will get back on it next week. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
@yakkomajuri let's split the PoE work at HogQL into two parts:
I merged with master and started to cleaning up the person_overrides table you added here, only to realise we have 4 identical tables we select from with argmax joins. Thus it was time for a common solution (and one more step towards becoming an ORM 😅). This PR now adds:
If you find this all a-OK and the tests pass, I'll happily ✅ and 🚢 🇮🇹 |
I'd like to test PoEv2 locally. Are there any specific flags I can enable and things I can do to get any data to come in to the person_overrides table? I was flying blind until now :) |
I merged this PR in (despite my own many changes), as it is just step 1 in poev2 support that adds a table we can query in step 2. Plus it improves some errors I just saw in #sentry. |
Just putting this up as I've been spending a good amount of time on it (and have other things to do) while I feel it might be a quick thing for @mariusandra.
Essentially, seems most of the PoE v2 stuff is in place here, but I need the person_id field in PoE v2 to be an alias to
if(notEmpty(...), ...)
seems I'd need to edit the printer to do this? Could probably figure out a way but wondering what the suggested approach here would be