chore(hogql): consolidate all parts of HogQL under one feature flag (and enable HogQL beta) #14871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏮 Merging this enables "SQL insights" for the beta users cohort, and for those explicitly added to the event explorer beta 🏮
Problem
Releasing HogQL is tricky. There are 4 different flags you must enable (
hogql-queries,data-exploration-live-events,database,data-exploration-query-tab) for each user who wants access to all parts of HogQL.We'll still keep HogQL in a private/flagged beta for a little bit, and we need an easy way to add users to the beta.
Changes
hogql.hogqlflag. Keeping this backend flag allows us to quickly shut everything down if we need to. This however means that once you add users to the flag, it might take a minute or so before the backend gets the new flag and actually allows the queries for them.How did you test this code?
Clicking things locally still worked.