chore(hogql): rename /query to /debug #14729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Mar 14, 2023
|
Nice! Just what's up with storybook though 🤔 |
|
I wonder if it will fail in a fresh PR #14731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
/queryendpoint looks like a user-facing playground, but it's our internal debug area. Having a URL like/querymeans people will find it and have weird expectations on what they'll find. Most will probably be confused about the JSON data exploration node structure, and just expect a text area.Changes
Renames the
/queryURL to/debug.How did you test this code?
Checked in my browser