chore(hogql): rename symbols to pointers #14411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into hogql-symbol-resolution
|
Of the two choices, "pointer" is a bit uncommon. Usually, pointer is reserved for the C/C++ concept of a pointer to a memory address. "Ref" or "reference" is quite common, and I would choose it if there aren't any other considerations (e.g. overlapping with some other domain-specific concept). |
|
There seems to be broad consensus that this name isn't a good choice. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The word "symbol" means something else in language parsers. Think of Ruby, which has
Symbolas a separate class along String (symbols get stored in a global hash table, strings don't), or ECMAScript'sSymbolobject.Changes
Renames all
symbol-s topointer-s to see if that makes anything clearer.Remember, in our case, a "Symbol" is a data structure, which has the following role. In the query
select a.timestamp as b from events a, a "symbol" assigned to each part of the query will refer back to the value's source. So in this case "b" will link to "a.timestamp", which will link to the database field of that name, in a linked list of "symbols" or "refs" in this case.There's also an alternative proposal out there to rename symbols to "refs".
How did you test this code?
Didn't.