Skip to content

feat(hogql): intervals #14370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

feat(hogql): intervals #14370

merged 1 commit into from
Feb 22, 2023

Conversation

mariusandra
Copy link
Collaborator

Changes

Support syntax like interval 1 month to be able to make queries like:

   select event,
          properties.$geoip_country_name as `Country Name`,
          count() as `Event count`
     from events
    where timestamp > now() - interval 1 month
 group by event,
          properties.$geoip_country_name
 order by count() desc
    limit 100

Currently you'd have to write toIntervalMonth(1), which is supported, but does not look that good.

How did you test this code?

Added tests. Tested in the browser.

@mariusandra mariusandra mentioned this pull request Feb 22, 2023
Open
@mariusandra mariusandra merged commit 9a6da61 into master Feb 22, 2023
@mariusandra mariusandra deleted the hogql-interval branch February 22, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr Awaiting requested review from thmsobrmlr

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

1 more reviewer

@yakkomajuri yakkomajuri yakkomajuri approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @yakkomajuri