Skip to content

Conversation

neilkakkar
Copy link
Contributor

Changes

on the tin^ companion to PostHog/posthog-js#613
Please describe.

Add screenshots or screen recordings for visual / UI-focused changes.

Checklist

  • Titles are in sentence case
  • Feature names are in sentence case too
  • Words are spelled using American English
  • I have checked out our style guide
  • If I moved a page, I added a redirect in vercel.json

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Apr 26, 2023 9:13am

Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor fixes and a question.


```js
// set properties for a group
posthog.groupPropertiesForFlags({'organization': {'property1': 'value', property2: 'value2'}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to do anything with the name of the group? Or just the type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the type! The group name itself is handled via posthog.group() . I'll add this too

Co-authored-by: Ian Vanagas <34755028+ivanagas@users.noreply.github.com>
@neilkakkar neilkakkar merged commit 52bca49 into master Apr 26, 2023
@neilkakkar neilkakkar deleted the neilkakkar-patch-3 branch April 26, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants