Skip to content

Add UUID to ID_TYPES #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

Add UUID to ID_TYPES #26

merged 1 commit into from
Apr 2, 2021

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 1, 2021

Makes UUID an accepted ID type. No changed in processing code needed, as stringify_id already str()-casts IDs. Resolves #25.

@Twixes Twixes requested a review from paolodamico April 1, 2021 15:33
@Twixes Twixes mentioned this pull request Apr 1, 2021
Closed
paolodamico
paolodamico approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paolodamico paolodamico merged commit 15ebe85 into master Apr 2, 2021
@paolodamico paolodamico deleted the distinct-uuid branch April 2, 2021 00:59
@neilkakkar neilkakkar mentioned this pull request May 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@paolodamico paolodamico paolodamico approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library does not accept uuid.UUID as distinct_id, but Posthog uses UUIDs internally
2 participants
@Twixes @paolodamico