Skip to content

chore: Bump version of CH to 22.3 LTS and switch dockerhub org from yandex to clickhouse inc #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 10, 2022
Merged

chore: Bump version of CH to 22.3 LTS and switch dockerhub org from yandex to clickhouse inc #381

merged 13 commits into from
Jun 10, 2022

Conversation

fuziontech
Copy link
Member

@fuziontech fuziontech commented May 11, 2022 •
edited
Loading

Description

Bump Clickhouse version for the chart to 22.3 LTS. Also move dockerhub organization from yandex to clickhouse inc. This provides us access to new versions of clickhouse and also removes yandex org as dependency.

Depends on PostHog/posthog#9743

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@fuziontech fuziontech changed the title Bump version of CH to 22.3 LTS and switch dockerhub org from yandex to clickhouse inc chore: Bump version of CH to 22.3 LTS and switch dockerhub org from yandex to clickhouse inc May 11, 2022
@fuziontech fuziontech added the bump minor Updates the chart version by 0.1.0 label May 11, 2022
@macobo macobo mentioned this pull request May 12, 2022
Merged
@guidoiaquinti
Copy link
Contributor

Why 22.3 instead of 21.11?

@fuziontech fuziontech added bump major Increases chart version to x+1.0.0 and removed bump minor Updates the chart version by 0.1.0 labels May 17, 2022
@fuziontech fuziontech requested a review from hazzadous May 17, 2022 21:03
@fuziontech
Copy link
Member Author

⚠️ DO NOT LAND THIS ⚠️
https://github.com/PostHog/charts-clickhouse/pull/381/files#diff-e5d75a211cc4472486a4b35840f9e60d261b574e167ab44decf6bf5e4b7c3606R15
This line needs to be replaced with the next revision's version. This has been temporarily changed to latest for CI.

Before pushing the release what we'll do is:

  • Include new chart version requirement in the new release notes
  • Update the major release notes that clickhouse upgrade will be required
  • Force CI to run all tests again on the testing release
  • Land PR this PR with new image tag pointing to 1.36.0

hazzadous
hazzadous reviewed May 17, 2022
View reviewed changes
ci/kubetest/test_clickhouse_different_image.py Outdated
@@ -8,7 +8,7 @@

clickhouse:
image:
tag: 21.9.2.17
tag: 21.11.11.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we specifically test that 21.11 is ok? And this is our lower bound on support?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a comment on why this is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely get a comment!

This was basically me thinking it through like this:
Our lower bound for support is set here:
PostHog/posthog@49c56fa#diff-1258eacbb566a96ca0256e0d341987e49c22c0077dc3128291903d21aec2ca93R15

So technically we support >=21.6.0,<22.4.0 for ClickHouse

We will be bumping up the requirement with the next release of PostHog and the chart so technically this should be set to 22.3, but that would be the same as what we are currently using. From what I understand of this test is that it is checking to make sure that we can still override the settings for what ClickHouse version we want to run on the stack. We could alternatively set to 22.3.6.5-alpine or just remove this test entirely.

charts/posthog/ALL_VALUES.md
@@ -181,8 +181,8 @@ The following table lists the configurable parameters of the PostHog chart and t
| clickhouse.password | string | `"a1f31e03-c88e-4ca6-a2df-ad49183d15d9"` | Clickhouse password |
| clickhouse.secure | bool | `false` | Whether to use TLS connection connecting to ClickHouse |
| clickhouse.verify | bool | `false` | Whether to verify TLS certificate on connection to ClickHouse |
| clickhouse.image.repository | string | `"yandex/clickhouse-server"` | ClickHouse image repository. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documentation auto generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah. Either that or @guidoiaquinti is very busy

image

https://github.com/PostHog/charts-clickhouse/blame/main/.github/workflows/update-docs.yml

@fuziontech fuziontech mentioned this pull request May 17, 2022
Closed
6 tasks
fuziontech
fuziontech commented May 25, 2022
View reviewed changes
charts/posthog/values.yaml Outdated
@@ -12,7 +12,7 @@ image:
# -- PostHog image tag to use (example: `release-1.35.0`).
tag:
# -- PostHog default image. Do not overwrite, use `image.sha` or `image.tag` instead.
default: ":release-1.35.0"
default: "release-1.36.0-unstable"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change this before landing!

@guidoiaquinti guidoiaquinti mentioned this pull request May 30, 2022
Merged
@guidoiaquinti guidoiaquinti mentioned this pull request May 30, 2022
Merged
4 tasks
@guidoiaquinti guidoiaquinti merged commit 6bbc096 into main Jun 10, 2022
@guidoiaquinti guidoiaquinti deleted the clickhouse_LTS branch June 10, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidoiaquinti guidoiaquinti Awaiting requested review from guidoiaquinti

@macobo macobo Awaiting requested review from macobo

1 more reviewer

@hazzadous hazzadous hazzadous left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bump major Increases chart version to x+1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuziontech @guidoiaquinti @hazzadous