Add overloaded wrapper methods for passing poselib::Camera instead of py::dict. #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pybind/pyposelib.cc
file, primarily focusing on refactoring function signatures to useCamera
objects directly instead ofpy::dict
for camera parameters. Additionally, it introduces overloaded functions to maintain compatibility with the previous interface.Refactoring for improved type safety:
estimate_absolute_pose_wrapper
,refine_absolute_pose_wrapper
,estimate_absolute_pose_pnpl_wrapper
, andrefine_absolute_pose_pnpl_wrapper
to acceptCamera
objects directly instead ofpy::dict
for camera parameters. [1] [2] [3] [4]estimate_generalized_absolute_pose_wrapper
andrefine_generalized_absolute_pose_wrapper
to useCamera
objects instead ofpy::dict
for camera parameters. [1] [2]Maintaining backward compatibility:
estimate_absolute_pose_wrapper
,refine_absolute_pose_wrapper
,estimate_absolute_pose_pnpl_wrapper
, andrefine_absolute_pose_pnpl_wrapper
that convertpy::dict
toCamera
objects internally. [1] [2] [3] [4]estimate_generalized_absolute_pose_wrapper
andrefine_generalized_absolute_pose_wrapper
to handlepy::dict
conversions. [1] [2]These changes improve type safety and maintain backward compatibility, ensuring a smooth transition to the new interface.