Skip to content

Conversation

uilianries
Copy link
Contributor

@uilianries uilianries commented Aug 6, 2024

Hello!

As asked in the comment #103 (comment), this PR brings the steps of installation for PoseLib, when using Conan.

I did not add how to install/configure Conan, because the embedded links has the content already, and it will avoid polluting the README file.

Currently, the version 2.0.3 is the latest available in Conan Center: https://conan.io/center/recipes/poselib?version=2.0.3

There is a PR in ConanCenterIndex including the version 2.0.4, as well: conan-io/conan-center-index#24841

The command conan install --requires="poselib/[*]" --build=missing means:

  • conan install: Install a package from a remote. By default, it points to the official Conan Center
  • --requires="poselib/[*]": Install the latest version of poselib available
  • --build=missing: In case not finding a pre-built package compatible, build it from source then.

Regards!

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@valgur
Copy link

valgur commented Aug 6, 2024

@uilianries I would recommend including a minimal conanfile.txt with CMakeDeps and cmake_layout:

[requires]
poselib/[*]

[generators]
CMakeToolchain
CMakeDeps

[layout]
cmake_layout

The plain install command only generates conanbuild.sh and conanrun.sh files, which I imaging would be a frustratingly confusing output if I were to be using Conan for the first time.

Or maybe link to https://docs.conan.io/2/tutorial/consuming_packages/build_simple_cmake_project.html and simply mention that you can include poselib/[*] under [requires] in a conanfile.txt to get started.

@uilianries
Copy link
Contributor Author

@uilianries I would recommend including a minimal conanfile.txt with CMakeDeps and cmake_layout:

[requires]
poselib/[*]

[generators]
CMakeToolchain
CMakeDeps

[layout]
cmake_layout

The plain install command only generates conanbuild.sh and conanrun.sh files, which I imaging would be a frustratingly confusing output if I were to be using Conan for the first time.

Or maybe link to docs.conan.io/2/tutorial/consuming_packages/build_simple_cmake_project.html and simply mention that you can include poselib/[*] under [requires] in a conanfile.txt to get started.

I would prefer not:

  • The conanfile.txt is consuming poselib itself, not solve dependencies that could be used by the CI or the author
  • Any question about, users will point this repository not Conan. Even if is documented, from my experience is: people barely read docs.

@valgur
Copy link

valgur commented Aug 6, 2024

Actually, I think a simple link to https://conan.io/center/recipes/poselib or a
[![Conan Center](https://img.shields.io/conan/v/poselib)](https://conan.io/center/recipes/poselib)
Conan Center
badge at the top of the readme would be sufficient. The guide on the package pages is quite good to get started.

@pablospe
Copy link
Collaborator

pablospe commented Aug 6, 2024

I think it would be nice to add the badge.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Contributor Author

Done, Conan badge has been added on the top of the README.md

@pablospe pablospe merged commit c0a09e8 into PoseLib:master Aug 7, 2024
1 check passed
@pablospe
Copy link
Collaborator

pablospe commented Aug 7, 2024

thanks!

@pablospe
Copy link
Collaborator

@uilianries @valgur how do we update the version to 2.0.5 of the conan package? It seems that the BrewTestBot is working but I don't see a new version.

@uilianries
Copy link
Contributor Author

@pablospe Hello! There is a documented process in the ConanCenterIndex repository: https://github.com/conan-io/conan-center-index/blob/master/docs/bump_version.md

In summary, you can open a PR directly.

Regards!

@Parskatt
Copy link
Collaborator

Parskatt commented Aug 28, 2025

So just add 2.0.5 in https://github.com/conan-io/conan-center-index/blob/master/recipes%2Fposelib%2Fconfig.yml and conandata.yml and PR?

@uilianries
Copy link
Contributor Author

So just add 2.0.5 in conan-io/conan-center-index@master/recipes%2Fposelib%2Fconfig.yml and PR?

And update the https://github.com/conan-io/conan-center-index/blob/master/recipes/poselib/all/conandata.yml with that new version and its URL + SHA256

@Parskatt
Copy link
Collaborator

@pablospe made a PR

@Parskatt
Copy link
Collaborator

@pablospe My naive PR (conan-io/conan-center-index#28279) fails due to some ad-hoc stuff in conanfile.py#L86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants