Skip to content

Add node field to PolymerDomApi #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Add node field to PolymerDomApi #5598

merged 1 commit into from
Oct 18, 2019

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Oct 18, 2019

And keep DomApiNative type compatible with PolymerDomApi.

Upstreaming cl/275091781

@rictic
Add node field to PolymerDomApi
15747c8 
And keep DomApiNative type compatible with PolymerDomApi.

Upstreaming cl/275091781
@rictic rictic requested a review from aomarks October 18, 2019 06:56
@aomarks
Copy link
Member

aomarks commented Oct 18, 2019

I think this should go to legacy-undefined-noBatch, since that's what Google tracks?

@kevinpschaaf
Copy link
Member

Either place... we're regularly merging master into legacy-undefined-noBatch.

@kevinpschaaf
Copy link
Member

Curious what was relying on node? It's basically an implementation detail of the PolymerDomAPI class (despite it not being prefixed), so it smells odd that something would reference it.

@rictic
Copy link
Contributor Author

rictic commented Oct 18, 2019

It looks like it's from a desire to unwrap a PolymerDomApi value back to its underlying dom value in order to pass it to a basic DOM handling API. Might have been totally based on a type error from the compiler and it may have worked fine at runtime, in which case maybe they should just cast the PolymerDomApi as a Node instead.

To check out the code, see http://cs/setPolymerNodeContent

@kevinpschaaf
Copy link
Member

@sorvell Can you review?

sorvell
sorvell approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is basically fine. The original intent was that this was private, but it was never marked so and it's not going to change at this point so it seems ok.

@sorvell sorvell merged commit 8c69fb8 into master Oct 18, 2019
@sorvell sorvell deleted the polymer-dom-api branch October 18, 2019 21:24
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomarks aomarks Awaiting requested review from aomarks

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

1 more reviewer

@sorvell sorvell sorvell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rictic @aomarks @kevinpschaaf @sorvell @googlebot