Skip to content

Don't set display: none under legacyOptimizations. Fixes #5541. #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2019
Merged

Don't set display: none under legacyOptimizations. Fixes #5541. #5542

merged 1 commit into from
May 17, 2019

Conversation

kevinpschaaf
Copy link
Member

Elide setting style on template elements if legacyOptimizations is on.

Reference Issue

Fixes #5541.

TimvdLippe
TimvdLippe approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@kevinpschaaf kevinpschaaf merged commit 4f40589 into master May 17, 2019
@kevinpschaaf kevinpschaaf deleted the 5541-kschaaf-template-display branch May 17, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreedm dfreedm Awaiting requested review from dfreedm

2 more reviewers

@sorvell sorvell sorvell approved these changes

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid cost of setting display:none under legacyOptimizations
4 participants
@kevinpschaaf @sorvell @TimvdLippe @googlebot