Skip to content

Check directly for // in resolveUrl because it isn't a valid URL #5531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2019
Merged

Check directly for // in resolveUrl because it isn't a valid URL #5531

merged 2 commits into from
May 3, 2019

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented May 1, 2019

Upstreaming cl/245302268

@aomarks aomarks requested review from sorvell and kevinpschaaf May 1, 2019 19:34
@aomarks aomarks requested review from dfreedm and TimvdLippe as code owners May 1, 2019 19:34
sorvell
sorvell suggested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test please? Thanks.

@aomarks
Copy link
Member Author

aomarks commented May 2, 2019

Can we add a test please? Thanks.

Done

@aomarks aomarks merged commit 969f289 into master May 3, 2019
@aomarks aomarks deleted the resolve-url branch May 3, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@dfreedm dfreedm Awaiting requested review from dfreedm

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

1 more reviewer

@sorvell sorvell sorvell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aomarks @sorvell @googlebot