Skip to content

Ensure the debouncer is not already canceled before canceling. #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

Ensure the debouncer is not already canceled before canceling. #5508

merged 2 commits into from
Mar 8, 2019

Conversation

kevinpschaaf
Copy link
Member

The initial fix for #5250 had a flaw that could lead to an async task being canceled twice (found in internal testing).

Reference Issue

Fixes #5250

sorvell
sorvell reviewed Mar 7, 2019
View reviewed changes
@sorvell sorvell merged commit ef82ddf into master Mar 8, 2019
@sorvell sorvell deleted the 5250-ensure-canceled branch March 8, 2019 00:44
@kevinpschaaf kevinpschaaf mentioned this pull request Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreedm dfreedm Awaiting requested review from dfreedm

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

1 more reviewer

@sorvell sorvell sorvell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dom-if memory leak
3 participants
@kevinpschaaf @sorvell @googlebot