fixing deletion ordering #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b56fdd8 to
939de39
Compare
javier-op
approved these changes
Jul 14, 2022
KalonJ-MSFT
reviewed
Jul 14, 2022
| @@ -174,14 +177,15 @@ var _ = Describe("allocation API service queue tests", func() { | |||
|
|
|||
| // downscale the Build to one standingBy | |||
| Eventually(func(g Gomega) { | |||
| testVerifyStandingByActiveByCount(context.Background(), buildID1, 2, 2) | |||
| testVerifyGameServerStates(context.Background(), buildID1, testStates{0, 0, 2, 2}) | |||
There was a problem hiding this comment.
guess that applies everywhere
| // then the ones on Initializing state | ||
| // and lastly the ones on StandingBy state | ||
| // GameServers that have crashed or Terminated are taken care of when the GameServerBuild controller starts | ||
| func getValueByState(gs *mpsv1alpha1.GameServer) int { |
There was a problem hiding this comment.
is there no concept of switches in Go?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downscaling, the GameServerBuild controller did not distinguish between Initializing and StandingBy GameServers. If a GameServerBuild is upscaling (e.g. waiting for a new Node to join the cluster) and the user starts a downscaling, this can have the impact of StandingBy GameServers being deleted before the Initializing ones. This way, the GameServerBuild will be a little slower to reach the required StandingBy levels.
This PR adds some logic to the GameServerBuild controller to sort the GameServer slice before deletion, so that the Initializing GameServers come before the StandiingBy.
Opportunistically, we refactored the tests on the GameServerBuild controller.