adding datetime for state transitions #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cacb15 to
b82bc93
Compare
dd68c63 to
4a2c5b4
Compare
javier-op
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265
This PR adds extra fields on GameServer.Status that contain the date/time of when the GameServer transitioned to a specific state.
Backstory:
I've spent some time on this trying to add a slice of state transition objects, similar to the PodConditions one. However, it's been really tricky to patch it, since strategic merge patch doesn't work for CRDs (kubernetes/kubernetes#58414). This would make it hard to patch the status object from inside NodeAgent since we don't keep track of the entire GameServer object. Thus, we opted for a simpler solution which is to inject 3 extra fields on the GameServer.Status object.