Skip to content

Added support for windows containers #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 12, 2022
Merged

Added support for windows containers #241

merged 22 commits into from
May 12, 2022

Conversation

javier-op
Copy link
Contributor

Implements #8

javier-op added 21 commits May 3, 2022 12:00
@javier-op
Added node selector to yaml files so manager and current nodeagent de…
dbe1311 
…ploy only on linux
@javier-op
Added install yaml file for netcore sample in windows
2d03c3f
@javier-op
Added powershell script for building windows docker images
2ab94bc
@javier-op
Fixed monitoring docs
c444b7c
@javier-op
Added Dockerfiles for windows containers
cf1823d
@javier-op
Updated container image on netcore sample for windows
00f307f
@javier-op
Added new windows containers to the install yaml files
21cc3bc
@javier-op
Updated script for building windows images
8dd10f6
@javier-op
Added workflow for publishing windows docker images
1f8ac6b
@javier-op
Merge branch 'main' into windows_containers
c0dbf5f
@javier-op
Fixed missing env var in unit tests
e41185b
@javier-op
Merge branch 'windows_containers' of github.com:PlayFab/thundernetes …
9eed5e2 
…into windows_containers
@javier-op
Delete workflow file, I'll create it on a different way
15cdb22
@javier-op
Testing workflow
c633d06
@javier-op
Fixed powershell for building windows images
e114ef3
@javier-op
Fix for powershell script 2
d2a8746
@javier-op
Test for workflow
1f19297
@javier-op
Fix powershell script 3
283e075
@javier-op
Fixed var name in powershell script
c3a9aa6
@javier-op
Removed trigger on pull request for new workflow
6b956c1
@javier-op
Added some docs
4040156
@javier-op javier-op marked this pull request as ready for review May 11, 2022 14:56
@javier-op javier-op requested review from dgkanatsios and khaines May 11, 2022 14:57
@dgkanatsios
Copy link
Collaborator 

  It("should attach init container", func() {

can we add a test for Windows? It would make a difference if we (by mistake) change one of the fieldnames etc.

Refers to: pkg/operator/controllers/utilities_test.go:137 in 4040156. [](commit_id = 4040156, deletion_comment = False)

dgkanatsios
dgkanatsios reviewed May 11, 2022
View reviewed changes
dgkanatsios
dgkanatsios reviewed May 11, 2022
View reviewed changes
dgkanatsios
dgkanatsios reviewed May 11, 2022
View reviewed changes
dgkanatsios
dgkanatsios approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@dgkanatsios dgkanatsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@javier-op javier-op merged commit 86a8512 into main May 12, 2022
@javier-op javier-op deleted the windows_containers branch May 12, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgkanatsios dgkanatsios dgkanatsios approved these changes

@khaines khaines Awaiting requested review from khaines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javier-op @dgkanatsios