Skip to content

allocate on the newest node #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 13, 2022
Merged

allocate on the newest node #230

merged 9 commits into from
May 13, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Apr 19, 2022 •
edited
Loading

Fixes #7

This PR

  • introduces a new field in the GameServer status that contains the age of the Node in days
  • modifies the allocation algorithm to allocate on the newest node

@dgkanatsios dgkanatsios force-pushed the allocations branch 5 times, most recently from e20ba1f to 0c5d4e8 Compare April 26, 2022 01:25
@dgkanatsios dgkanatsios force-pushed the allocations branch 12 times, most recently from 8655f80 to f12a9d5 Compare May 4, 2022 21:17
javier-op
javier-op reviewed May 6, 2022
View reviewed changes
@dgkanatsios dgkanatsios force-pushed the allocations branch 11 times, most recently from c7d391e to 1c65240 Compare May 11, 2022 23:03
@dgkanatsios dgkanatsios force-pushed the allocations branch 3 times, most recently from 87db4e7 to 14ca5f7 Compare May 11, 2022 23:27
@dgkanatsios dgkanatsios marked this pull request as ready for review May 11, 2022 23:27
@dgkanatsios dgkanatsios requested review from javier-op and khaines May 11, 2022 23:27
javier-op
javier-op reviewed May 12, 2022
View reviewed changes
javier-op
javier-op reviewed May 12, 2022
View reviewed changes
javier-op
javier-op reviewed May 12, 2022
View reviewed changes
@dgkanatsios dgkanatsios added area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running area/performance Anything related to thundernetes improvements for speed, or issues related to being slow. labels May 13, 2022
javier-op
javier-op reviewed May 13, 2022
View reviewed changes
javier-op
javier-op approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@javier-op javier-op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dgkanatsios dgkanatsios merged commit c16cd23 into main May 13, 2022
@dgkanatsios dgkanatsios deleted the allocations branch May 13, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaines khaines Awaiting requested review from khaines

1 more reviewer

@javier-op javier-op javier-op approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/performance Anything related to thundernetes improvements for speed, or issues related to being slow. area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allocation re-architecture
2 participants
@dgkanatsios @javier-op