Skip to content

adding min and max port #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2022
Merged

adding min and max port #181

merged 2 commits into from
Mar 11, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Mar 10, 2022 •
edited
Loading

Fixes #175
This PR:

  • grabs the ports that PortRegistry uses to assign ports to GameServers from environment variables MIN_PORT and MAX_PORT
  • if both environment variables are missing, Thundernetes sets the default to 10000 and 12000, respectively
  • updates the relevant documentation

@dgkanatsios dgkanatsios force-pushed the minmaxport branch 3 times, most recently from 94f7719 to 785e344 Compare March 10, 2022 23:39
@dgkanatsios dgkanatsios marked this pull request as ready for review March 10, 2022 23:53
@dgkanatsios dgkanatsios requested review from khaines and AmieDD March 10, 2022 23:54
@dgkanatsios dgkanatsios merged commit 7e9d174 into main Mar 11, 2022
@dgkanatsios dgkanatsios deleted the minmaxport branch March 11, 2022 01:18
@dgkanatsios dgkanatsios added the area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaines khaines khaines approved these changes

@AmieDD AmieDD Awaiting requested review from AmieDD

Assignees
No one assigned
Labels
area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameterize MIN_PORT and MAX_PORT
2 participants
@dgkanatsios @khaines