Skip to content

refactoring nodeagent #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2022
Merged

refactoring nodeagent #174

merged 3 commits into from
Mar 17, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Mar 3, 2022 •
edited
Loading

This PR is an attempt at code simplication and refactoring of the NodeAgent.

  • unifies the approach to the watch's onCreate and onUpdate methods
  • adds lots of code comments to make the approach more clear to the reader

@dgkanatsios dgkanatsios force-pushed the refactoringnodeagent branch 4 times, most recently from fb4c3cf to f2589ec Compare March 3, 2022 23:51
@dgkanatsios dgkanatsios marked this pull request as ready for review March 4, 2022 00:02
@dgkanatsios dgkanatsios requested a review from khaines March 4, 2022 00:04
@dgkanatsios dgkanatsios force-pushed the refactoringnodeagent branch 16 times, most recently from a5c9cbf to 918b49d Compare March 5, 2022 08:09
@dgkanatsios dgkanatsios added this to the 0.3.0 milestone Mar 10, 2022
@dgkanatsios dgkanatsios force-pushed the refactoringnodeagent branch from 748f2c7 to e95a405 Compare March 11, 2022 01:35
@dgkanatsios dgkanatsios force-pushed the refactoringnodeagent branch from e95a405 to f8594e8 Compare March 11, 2022 23:49
khaines
khaines reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues, but should consider them before merging. Rest looks great

@dgkanatsios dgkanatsios merged commit f767382 into main Mar 17, 2022
@dgkanatsios dgkanatsios deleted the refactoringnodeagent branch March 17, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaines khaines khaines approved these changes

Assignees
No one assigned
Labels
code-quality
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgkanatsios @khaines